-
Couldn't load subscription status.
- Fork 228
Fix FastCC #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FastCC #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly checked for style etc. Perhaps @dagl1 could look at the functional side, I'm not into the matter at the moment.
|
@Midnighter Ah sorry I didn't realise things required checking. Some small things in regards to the code (but both of you are my seniors so take them as questions) |
|
Thank you for your evaluation @dagl1.
It's not so much that it's strictly required but since most of us work alone rather than pair program, it's always better to have a second pair of eyes. |
This brings the method in line with the paper. Still not super fast but it works. Still missing some more tests.